Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed point functionality in Basic Calculator #820

Merged
merged 8 commits into from
May 25, 2024
Merged

Fixed point functionality in Basic Calculator #820

merged 8 commits into from
May 25, 2024

Conversation

shivangi-singhjha
Copy link
Contributor

@shivangi-singhjha shivangi-singhjha commented May 24, 2024 •
edited
Loading

Fixes Issue🛠️

Closes #634

Description👨‍💻

Added additional functionalities in the basic calculator for the point "."

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested on various test cases manually.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

WhatsApp Image 2024-05-23 at 01 04 22_004cc9f6

WhatsApp Image 2024-05-23 at 02 27 01_b2ba3854

WhatsApp Image 2024-05-23 at 02 33 13_38e724cd

github-actions[bot]
github-actions bot reviewed May 24, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shivangi-singhjha, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@netlify Netlify
Copy link

netlify bot commented May 24, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 367cb23
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66522db53f789b0008d9b541
😎 Deploy Preview https://deploy-preview-820--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivangi-singhjha shivangi-singhjha mentioned this pull request May 24, 2024
Closed
@shivangi-singhjha
Copy link
Contributor Author

Sir kindly label this PR with GSSOC.

@Rakesh9100 Rakesh9100 changed the title Basic calculator Added point functionality to Basic Calculator May 25, 2024
@Rakesh9100
Copy link
Owner

It is working in the UI only, pls do the same when user type point from the keyboard @shivangi-singhjha

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 25, 2024
@shivangi-singhjha
Copy link
Contributor Author

It is working in the UI only, pls do the same when user type point from the keyboard @shivangi-singhjha

Sir I have updated it. Kindly look into it.
Please label it under gssoc

@Rakesh9100 Rakesh9100 merged commit e3e0d47 into Rakesh9100:main May 25, 2024
4 checks passed
@Rakesh9100 Rakesh9100 changed the title Added point functionality to Basic Calculator Fixed point functionality in Basic Calculator May 25, 2024
@Rakesh9100
Copy link
Owner

Good, Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @shivangi-singhjha

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task and removed question 🤔 Further information is requested labels May 25, 2024
@shivangi-singhjha
Copy link
Contributor Author

Good, Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @shivangi-singhjha

Thank You! So much sir🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@shivangi-singhjha shivangi-singhjha

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix point functionality in Basic Calculator
2 participants
@shivangi-singhjha @Rakesh9100